New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(asset): add headers to StoreArgs #928

Merged

krpeacock merged 2 commits into main from asset-header

Sep 13, 2024

Contributor

chenyan-dfinity commented Sep 13, 2024

Description

Allow to pass in headers when storing asset

Fixes #924

How Has This Been Tested?

Type check

Checklist:

My changes follow the guidelines in CONTRIBUTING.md.
The title of this PR complies with Conventional Commits.
I have edited the CHANGELOG accordingly.
I have made corresponding changes to the documentation.


          add headers to StoreArgs

5817b04

chenyan-dfinity requested a review from a team as a code owner

September 13, 2024 04:19

Contributor

github-actions bot commented Sep 13, 2024 •

edited

Loading

size-limit report 📦

Path	Size
@dfinity/agent	86.33 KB (0%)
@dfinity/candid	13.58 KB (0%)
@dfinity/principal	4.97 KB (0%)
@dfinity/auth-client	60.42 KB (0%)
@dfinity/assets	81.16 KB (+0.04% 🔺)
@dfinity/identity	57.65 KB (0%)
@dfinity/identity-secp256k1	131.89 KB (0%)

fix

04084cd

krpeacock approved these changes

View reviewed changes

krpeacock merged commit 6310461 into main

16 checks passed

krpeacock deleted the asset-header branch

September 13, 2024 17:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet